Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Context Deadline During Probe Calls #386

Merged
merged 5 commits into from
Dec 26, 2024

Conversation

falfaroc
Copy link
Contributor

Description

Update the incoming context deadline to the defaultAPITimeout (5s) if the request deadline is longer than that. This adjustment is to avoid long waits and out of sync situations when an array is unreachable and the environment does not respond in a reasonable time (within 5 seconds).

Also, adjust the timeout of the probing during BeforeServe to less than 2 seconds because in a similar situation as above, all other containers are waiting for a response within the time to properly connect to the csi.sock. If we don't adhere to this, multiple restarts occur during boot.

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#1612

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Backward compatibility is not broken

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Ensured that all unit tests are still passing as expected.
  • Ensured that the bootup sequence is not affected with zoning and non-zoning configuration.
  • Ensured that volume creation is working as expected.

@falfaroc falfaroc force-pushed the usr/falfaroc/probe-test branch from 1bb5392 to 6fec139 Compare December 24, 2024 17:28
@falfaroc falfaroc marked this pull request as ready for review December 24, 2024 17:31
@AkshaySainiDell AkshaySainiDell merged commit dab475a into main Dec 26, 2024
6 checks passed
@AkshaySainiDell AkshaySainiDell deleted the usr/falfaroc/probe-test branch December 26, 2024 05:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants